[dv] Small tidy-ups in dv_base_reg_field#29630
Open
rswarbrick wants to merge 2 commits intolowRISC:masterfrom
Open
[dv] Small tidy-ups in dv_base_reg_field#29630rswarbrick wants to merge 2 commits intolowRISC:masterfrom
rswarbrick wants to merge 2 commits intolowRISC:masterfrom
Conversation
This can be done in the configure function, which makes things rather simpler. Use that instead. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
No functional change, but this avoids a lint warning from Verissimo (and adds a comment to explain what's going on). Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
added
Component:DV
rswarbrick
requested review from
eshapira and
martin-velay
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are just code simplifications (and shortenings). No functional change.